From: Saeed Mahameed <sae...@mellanox.com> Date: Thu, 2 Jul 2020 15:19:12 -0700
> This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. This needs more work. I agree with Jakub that duplicating standard stats in ethtool -S is and has always been a very bad idea. We let people get away with it initially in order to allow per-queue stats, but that was a mistake and even if it was the right way forward it doesn't mean the rest of the ip -s stats should have been duplicated as well. Jakub's base argument is true, if we ever do something better in the generic 'ip -s' stuff it will not propagate to all of the 'ethtool -S' because it is duplicated around in every driver. We let driver developers get away with a lot with ethtool custom statistics and we're past due to perform some push back on this issue. There also seems to be some necessary discussion about where the tc reference count fix really belongs.
