On Mon, 12 Mar 2007 14:15:50 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 12 Mar 2007 14:08:21 -0700 > > > The TCP statistics shouldn't be located in the middle of the > > read_mostly section surrounded by sysctl values. > > Move EXPORT_SYMBOL next to data like other declarations near by. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > Stephen, they are pointers to the statistics, not the statistic > counters themselves. We're marking the _pointers_ as __read_mostly > here. > > When Eric originally submitted the change to add __read_mostly here I > didn't understand it either. > > Look at the definition of DEFINE_SNMP_STAT(). Okay, that's confusing. And maybe the comment suggests future work: /* * FIXME: On x86 and some other CPUs the split into user and softirq parts * is not needed because addl $1,memory is atomic against interrupts (but * atomic_inc would be overkill because of the lock cycles). Wants new * nonlocked_atomic_inc() primitives -AK */ -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
