Hi Vaibhav, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc3 next-20200702] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/smsc-use-generic-power-management/20200702-185914 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cd77006e01b3198c75fb7819b3d0ff89709539bb config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 003a086ffc0d1affbb8300b36225fb8150a2d40a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/net/ethernet/smsc/smsc9420.c:1466:6: warning: variable 'err' is used >> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (netif_running(dev)) { ^~~~~~~~~~~~~~~~~~ drivers/net/ethernet/smsc/smsc9420.c:1471:9: note: uninitialized use occurs here return err; ^~~ drivers/net/ethernet/smsc/smsc9420.c:1466:2: note: remove the 'if' if its condition is always true if (netif_running(dev)) { ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/smsc/smsc9420.c:1460:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 warning generated. vim +1466 drivers/net/ethernet/smsc/smsc9420.c 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1456 7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1457 static int __maybe_unused smsc9420_resume(struct device *dev_d) 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1458 { 7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1459 struct net_device *dev = dev_get_drvdata(dev_d); 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1460 int err; 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1461 7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1462 pci_set_master(to_pci_dev(dev_d)); 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1463 7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1464 device_wakeup_disable(dev_d); 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1465 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 @1466 if (netif_running(dev)) { b5a80837b7e125 drivers/net/ethernet/smsc/smsc9420.c Francois Romieu 2012-03-09 1467 /* FIXME: gross. It looks like ancient PM relic.*/ 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1468 err = smsc9420_open(dev); 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1469 netif_device_attach(dev); 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1470 } 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1471 return err; 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1472 } 2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1473 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
