On 3/12/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
On Mon, Mar 12, 2007 at 01:26:52AM -0300, Arnaldo Carvalho de Melo wrote:
> For the common, open coded 'skb->nh.raw = skb->data' operation, so that we
> can
> later turn skb->nh.raw into a offset, reducing the size of struct sk_buff in
> 64bit land while possibly keeping it as a pointer on 32bit.
>
> This one touches just the most simple case, next will handle the slightly
> more
> "complex" cases.
I don't like the naming. Either it should skb_reset_nh to match the field
name (with a good kdoc comment explaning what nh means), or the field
name should be network_header aswell. In general I'd prefer the shorter
names.
The fields will be renamed down the line, when their life as a union
of pointers will end, becoming just offsets.
But besides the naming issue this looks like a very nice way to go down.
:-)
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
