On 01.07.2020 20:09, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Wed, Jul 01, 2020 at 07:51:27PM +0300, Codrin Ciubotariu wrote:
>> The number of ports is incorrectly set to the maximum available for a DSA
>> switch. Even if the extra ports are not used, this causes some functions
>> to be called later, like port_disable() and port_stp_state_set(). If the
>> driver doesn't check the port index, it will end up modifying unknown
>> registers.
>>
>> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
>
> Hi Codrin
>
> You don't indicate which tree this is for. net-next, or net? It looks
> like it fixes a real issue, so it probably should be for net. But
> patches to net should be minimal. Is it possible to do the
>
> ds->num_ports = swdev->port_cnt;
>
> without all the other changes? You can then have a refactoring patch
> in net-next.
This one should be for net. Ok then, I will send a simpler version of
this patch for net, just to fix the issue and another one like this one
for net-next.
Thanks and best regards,
Codrin
>
> Thanks
> Andrew
>
