On Wed, Jul 1, 2020 at 8:02 AM Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > > On Tue, Jun 30, 2020 at 11:46 PM Andrii Nakryiko <andr...@fb.com> wrote: > > > > Fix bpftool logic of stripping away const/volatile modifiers for all global > > variables during BPF skeleton generation. See patch #1 for details on when > > existing logic breaks and why it's important. Support special > > .strip_mods=true > > mode in btf_dump. Add selftests validating that everything works as > > expected. > > Why bother with the flag?
You mean btf_dump should do this always? That's a bit too invasive a change, I don't like it. > It looks like bugfix to me. It can be considered a bug fix for bpftool's skeleton generation, but it depends on non-trivial changes in libbpf, which are not bug fix per se, so should probably better go through bpf-next.
