On 6/22/20 7:22 PM, Yonghong Song wrote: > > > On 6/22/20 6:47 PM, Eric Dumazet wrote: & >> >> Why is the sk_fullsock(sk) needed ? > > The parameter 'sk' could be a sock_common. That is why the > helper name bpf_skc_to_udp6_sock implies. The sock_common cannot > access sk_protocol, hence we requires sk_fullsock(sk) here. > Did I miss anything? OK, if arbitrary sockets can land here, you need also to check sk_type
- [PATCH bpf-next v3 06/15] bpf: add bpf_skc_to_{tcp,tcp_t... Yonghong Song
- Re: [PATCH bpf-next v3 06/15] bpf: add bpf_skc_to_{... kernel test robot
- Re: [PATCH bpf-next v3 06/15] bpf: add bpf_skc_to_{... kernel test robot
- [PATCH bpf-next v3 07/15] net: bpf: add bpf_seq_afinfo i... Yonghong Song
- [PATCH bpf-next v3 12/15] tools/libbpf: add more common ... Yonghong Song
- [PATCH bpf-next v3 04/15] bpf: allow tracing programs to... Yonghong Song
- [PATCH bpf-next v3 02/15] net: bpf: implement bpf iterat... Yonghong Song
- [PATCH bpf-next v3 09/15] bpf: add bpf_skc_to_udp6_sock(... Yonghong Song
- Re: [PATCH bpf-next v3 09/15] bpf: add bpf_skc_to_u... Eric Dumazet
- Re: [PATCH bpf-next v3 09/15] bpf: add bpf_skc_... Yonghong Song
- Re: [PATCH bpf-next v3 09/15] bpf: add bpf_... Eric Dumazet
- Re: [PATCH bpf-next v3 09/15] bpf: add ... Yonghong Song
- Re: [PATCH bpf-next v3 09/15] bpf:... Eric Dumazet
- Re: [PATCH bpf-next v3 09/15] ... Yonghong Song
- [PATCH bpf-next v3 14/15] tools/bpf: add udp4/udp6 bpf i... Yonghong Song
- Re: [PATCH bpf-next v3 14/15] tools/bpf: add udp4/u... Andrii Nakryiko
- Re: [PATCH bpf-next v3 14/15] tools/bpf: add ud... Yonghong Song
- [PATCH bpf-next v3 05/15] bpf: add bpf_skc_to_tcp6_sock(... Yonghong Song
- Re: [PATCH bpf-next v3 05/15] bpf: add bpf_skc_to_t... kernel test robot
- Re: [PATCH bpf-next v3 05/15] bpf: add bpf_skc_to_t... kernel test robot
- Re: [PATCH bpf-next v3 05/15] bpf: add bpf_skc_to_t... Andrii Nakryiko