Hi Andrew, +Cc Maxime Chevallier
On Tue, Jun 09, 2020 at 03:28:48PM +0200, Andrew Lunn wrote: > On Tue, Jun 09, 2020 at 03:11:52PM +0200, Sascha Hauer wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode > > called DRSGMII. Depending on the Port MAC Control Register0 PortType > > setting this seems to be either an overclocked SGMII mode or 2500BaseX. > > > > This patch adds the necessary Serdes Configuration setting for the > > 2.5Gbps modes. There is no phy interface mode define for overclocked > > SGMII, so only 2500BaseX is handled for now. > > > > As phy_interface_mode_is_8023z() returns true for both > > PHY_INTERFACE_MODE_1000BASEX and PHY_INTERFACE_MODE_2500BASEX we > > explicitly test for 1000BaseX instead of using > > phy_interface_mode_is_8023z() to differentiate the different > > possibilities. > > Hi Sascha > > This seems like it should have a Fixes: tag, and be submitted to the > net tree. Please see the Networking FAQ. This might be a candidate for a Fixes: tag: | commit da58a931f248f423f917c3a0b3c94303aa30a738 | Author: Maxime Chevallier <maxime.chevall...@bootlin.com> | Date: Tue Sep 25 15:59:39 2018 +0200 | | net: mvneta: Add support for 2500Mbps SGMII What do you mean by "submitted to the net tree"? I usually send network driver related patches to netdev@vger.kernel.org and from there David applies them. Is there anything more to it I haven't respected? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
