On Sat, May 30, 2020 at 6:34 AM Ido Schimmel <ido...@idosch.org> wrote:
>
> On Thu, May 28, 2020 at 10:12:34PM -0700, Roopa Prabhu wrote:
> > From: Roopa Prabhu <ro...@cumulusnetworks.com>
>
> Hi Roopa,
>
> I noticed that sparse complains about the following problem in
> the original submission (not handled by current set):
>
> drivers/net/vxlan.c:884:41: warning: dereference of noderef expression
>
> Seems to be fixed by:
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 39bc10a7fd2e..ea7af03e0957 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -881,13 +881,13 @@ static int vxlan_fdb_nh_update(struct vxlan_dev *vxlan,
> struct vxlan_fdb *fdb,
> goto err_inval;
> }
>
> - if (!nh->is_group || !nh->nh_grp->mpath) {
> + nhg = rtnl_dereference(nh->nh_grp);
> + if (!nh->is_group || !nhg->mpath) {
> NL_SET_ERR_MSG(extack, "Nexthop is not a multipath
> group");
> goto err_inval;
> }
>
> /* check nexthop group family */
> - nhg = rtnl_dereference(nh->nh_grp);
> switch (vxlan->default_dst.remote_ip.sa.sa_family) {
> case AF_INET:
> if (!nhg->has_v4) {
>
> Assuming it's correct, can you please fold it into v2?
>
Thanks Ido. This makes sense. I will add it to v2.
