On 29/05/2020 18:42:47+0300, Vladimir Oltean wrote: > On Fri, 29 May 2020 at 12:03, Alexandre Belloni > <alexandre.bell...@bootlin.com> wrote: > > > > On 29/05/2020 11:30:43+0300, Vladimir Oltean wrote: > > > > As ocelot can be used in a DSA configuration (even if it is not > > > > implemented yet), I don't think this would be correct. From my point of > > > > view, felix and seville are part of the ocelot family. > > > > > > > > > > In this case, there would be a third driver in > > > drivers/net/dsa/ocelot/ocelot_vsc7511.c which uses the intermediate > > > felix_switch_ops from felix.c to access the ocelot core > > > implementation. Unless you have better naming suggestions? > > > > > > > I don't. Maybe felix.c should have been ocelot.c from the beginning but > > honestly, it doesn't matter that much. > > > > Technically Seville is not part of the Ocelot family but part of > Serval, but then again, it's just a marketing name, so it doesn't > really mean anything..
When I submitted ocelot, I was thinking we would have different drivers for jaguar, luton, ocelot, serval and serval-t. IIRC, ocelot is a subset of serval or at least, it is similar enough to share the same driver. > I am a bit reluctant to rename the DSA driver ops to "ocelot", since > it would be even more confusing for everyone to have a function > ocelot_dsa_set_ageing_time that calls ocelot_set_ageing_time. At least > this way, there's going to be some learning curve figuring out that > felix is an umbrella term for DSA ops, but there will be more naming > predictability. (at least that's how I see it) > I'm fine with the current naming, I was certainly not suggesting to change it. > > BTW, maybe we should merge the VITESSE FELIX ETHERNET SWITCH DRIVER and > > MICROSEMI ETHERNET SWITCH DRIVER entries in MAINTAINERS. You do much > > more work in drivers/net/ethernet/mscc/ than I currently do. > > > > How would you see the merged MAINTAINERS entry? Something like this? > > MICROSEMI ETHERNET SWITCH DRIVER > M: Alexandre Belloni <alexandre.bell...@bootlin.com> > M: Microchip Linux Driver Support <unglinuxdri...@microchip.com> > M: Vladimir Oltean <vladimir.olt...@nxp.com> You should probably be in the top position. > M: Claudiu Manoil <claudiu.man...@nxp.com> > L: netdev@vger.kernel.org > S: Maintained I guess this could stay Supported unless you are not paid to work on that. > F: include/soc/mscc/ocelot* > F: drivers/net/ethernet/mscc/ > F: drivers/net/dsa/ocelot/* > F: net/dsa/tag_ocelot.c > > Any takers from Microchip, or is the internal mailing list enough? It seems ok for now, we can always add/replace people later on. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
