Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

[Andrzej Pietrasiewicz]

Hi Guenter,

W dniu 29.05.2020 o 16:48, Guenter Roeck pisze:

On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote:

Prepare for storing mode in struct thermal_zone_device.

Signed-off-by: Andrzej Pietrasiewicz <andrze...@collabora.com>
---
  drivers/acpi/thermal.c                        | 27 +++++++++----------
  drivers/platform/x86/acerhdf.c                |  8 ++++--
  .../intel/int340x_thermal/int3400_thermal.c   | 18 +++++--------
  3 files changed, 25 insertions(+), 28 deletions(-)

<snip>

@@ -544,27 +543,25 @@ static int thermal_set_mode(struct thermal_zone_device 
*thermal,
                                enum thermal_device_mode mode)
  {
        struct acpi_thermal *tz = thermal->devdata;
-       int enable;

if (!tz)

                return -EINVAL;

+ if (mode != THERMAL_DEVICE_DISABLED &&

+           mode != THERMAL_DEVICE_ENABLED)
+               return -EINVAL;

Personally I find this check unnecessary: The enum has no other values,
and it is verifyable that the callers provide the enum and not some other
value.

It is getting removed in PATCH 10/11.

+       if (mode != THERMAL_DEVICE_ENABLED &&
+           mode != THERMAL_DEVICE_DISABLED)
                return -EINVAL;

Same as above.

ditto.