On Mon, May 25, 2020 at 01:37:56AM +0000, Jianyong Wu wrote: > Hi Sudeep, > > > -----Original Message----- > > From: Sudeep Holla <sudeep.ho...@arm.com> > > Sent: Friday, May 22, 2020 9:12 PM > > To: Jianyong Wu <jianyong...@arm.com> > > Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > > m...@kernel.org; richardcoch...@gmail.com; Mark Rutland > > <mark.rutl...@arm.com>; w...@kernel.org; Suzuki Poulose > > <suzuki.poul...@arm.com>; Steven Price <steven.pr...@arm.com>; Justin > > He <justin...@arm.com>; Wei Chen <wei.c...@arm.com>; > > k...@vger.kernel.org; Steve Capper <steve.cap...@arm.com>; linux- > > ker...@vger.kernel.org; Kaly Xin <kaly....@arm.com>; nd <n...@arm.com>; > > Sudeep Holla <sudeep.ho...@arm.com>; kvm...@lists.cs.columbia.edu; > > linux-arm-ker...@lists.infradead.org > > Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. > > > > On Fri, May 22, 2020 at 04:37:16PM +0800, Jianyong Wu wrote: > > > Export arm_smccc_1_1_get_conduit then modules can use smccc helper > > > which adopts it. > > > > > > Acked-by: Mark Rutland <mark.rutl...@arm.com> > > > Signed-off-by: Jianyong Wu <jianyong...@arm.com> > > > --- > > > drivers/firmware/psci/psci.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/firmware/psci/psci.c > > > b/drivers/firmware/psci/psci.c index 2937d44b5df4..fd3c88f21b6a 100644 > > > --- a/drivers/firmware/psci/psci.c > > > +++ b/drivers/firmware/psci/psci.c > > > @@ -64,6 +64,7 @@ enum arm_smccc_conduit > > > arm_smccc_1_1_get_conduit(void) > > > > > > return psci_ops.conduit; > > > } > > > +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit); > > > > > > > I have moved this into drivers/firmware/smccc/smccc.c [1] Please update > > this accordingly. > > Ok, I will remove this patch next version.
You may need it still, just that this patch won't apply as the function is moved to a new file. -- Regards, Sudeep