Re: [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic for NXP imx8 chip

[David Miller]

From: Fugang Duan <fugang.d...@nxp.com>
Date: Mon, 25 May 2020 18:29:13 +0800

> +static int imx_dwmac_init(struct platform_device *pdev, void *priv)
> +{
> +     struct imx_priv_data *dwmac = priv;
> +     struct plat_stmmacenet_data *plat_dat = dwmac->plat_dat;
> +     int ret;
> +

Please code these sequences as:

        struct plat_stmmacenet_data *plat_dat;
        struct imx_priv_data *dwmac = priv;
        int ret;

        plat_dat = dwmac->plat_dat;

In order to have reverse christmas three local variable ordering.

THank you.