> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Tuesday, May 19, 2020 19:00 > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: da...@davemloft.net; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com > Subject: Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver > Updates 2020-05-19 > > On Tue, 19 May 2020 17:04:05 -0700 Jeff Kirsher wrote: > > This series contains updates to igc only. > > > > Sasha cleans up the igc driver code that is not used or needed. > > > > Vitaly cleans up driver code that was used to support Virtualization > > on a device that is not supported by igc, so remove the dead code. > > > > Andre renames a few macros to align with register and field names > > described in the data sheet. Also adds the VLAN Priority Queue Fliter > > and EType Queue Filter registers to the list of registers dumped by > > igc_get_regs(). Added additional debug messages and updated return > > codes for unsupported features. Refactored the VLAN priority > > filtering code to move the core logic into igc_main.c. Cleaned up > > duplicate code and useless code. > > No automated warnings :) > > It's a little strange how both TCI and ETYPE filters take the queue ID. > Looking at the code it's not immediately clear which one take precedence. Can > I install two rules for the same TCI and different ETYPE or vice versa? [Kirsher, Jeffrey T]
Adding Andre and Sasha to answer your questions, Jakub...
