When a new action is installed, firstuse field of 'tcf_t' is explicitly set
to 0. Value of zero means "new action, not yet used"; as a packet hits the
action, 'firstuse' is stamped with the current jiffies value.

tcf_tm_dump() should return 0 for firstuse if action has not yet been hit.

Fixes: 48d8ee1694dd ("net sched actions: aggregate dumping of actions timeinfo")
Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Roman Mashak <m...@mojatatu.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
---
 include/net/act_api.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/net/act_api.h b/include/net/act_api.h
index c24d7643548e..124bd139886c 100644
--- a/include/net/act_api.h
+++ b/include/net/act_api.h
@@ -75,7 +75,8 @@ static inline void tcf_tm_dump(struct tcf_t *dtm, const 
struct tcf_t *stm)
 {
        dtm->install = jiffies_to_clock_t(jiffies - stm->install);
        dtm->lastuse = jiffies_to_clock_t(jiffies - stm->lastuse);
-       dtm->firstuse = jiffies_to_clock_t(jiffies - stm->firstuse);
+       dtm->firstuse = stm->firstuse ?
+               jiffies_to_clock_t(jiffies - stm->firstuse) : 0;
        dtm->expires = jiffies_to_clock_t(stm->expires);
 }
 
-- 
2.7.4

Reply via email to