On 11/05/2020 23:36, Jakub Kicinski wrote: > Also with W=1: > > ../drivers/net/ethernet/sfc/siena.c:951:14: warning: symbol > 'siena_check_caps' was not declared. Should it be static? > 1a3,5 > ../drivers/net/ethernet/sfc/siena.c:951:14: warning: no previous prototype > for ‘siena_check_caps’ [-Wmissing-prototypes] > 951 | unsigned int siena_check_caps(const struct efx_nic *efx, > | ^~~~~~~~~~~~~~~~ Yup, it turns out not only is this missing 'static' but it's also not used — the assignment into siena_a0_nic_typeis missing, I must have screwed up a rebase at some point. I'll send a follow-up, since Dave has already applied it. Thanks for the review.
(And I'll try to get in the habit of checking the SOBs better; sorry about that. I'm still used to the old "first sign-off is the point of exit from the company" flow; plus I messed up my checkpatch invocation in a way that prevented it catching this.) -ed
