On Thu, 22 Feb 2007, John Heffner wrote:
> diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c
> index 7fd2910..a0c894f 100644
> --- a/net/ipv4/tcp_cong.c
> +++ b/net/ipv4/tcp_cong.c
> @@ -303,9 +303,9 @@ void tcp_slow_start(struct tcp_sock *tp)
>
> tp->snd_cwnd_cnt += cnt;
> while (tp->snd_cwnd_cnt >= tp->snd_cwnd) {
> + tp->snd_cwnd_cnt -= tp->snd_cwnd;
> if (tp->snd_cwnd < tp->snd_cwnd_clamp)
> tp->snd_cwnd++;
> - tp->snd_cwnd_cnt -= tp->snd_cwnd;
> }
> }
> EXPORT_SYMBOL_GPL(tcp_slow_start);
ACK. I was going to track this down tomorrow as I noticed strange
behavior during slow start while testing tcp-2.6 today but I don't have to
anymore :-). The problem I saw is now obvious, whole congestion control
was practically disabled due to underflow of the unsigned type that occurs
without this patch, causing TCP to be limited only by the receiver
advertized window during slow-start.
BTW, while looking this patch, I noticed that snd_cwnd_clamp is only u16
while snd_cwnd is u32, which seems rather strange since snd_cwnd is being
limited by the clamp value here and there?!?! And tcp_highspeed.c is
clearly assuming even more than this (but the problem is hidden as
snd_cwnd_clamp is feed back to the min_t and the used 32-bit constant
could be safely cut to 16-bits anyway):
tp->snd_cwnd_clamp = min_t(u32, tp->snd_cwnd_clamp, 0xffffffff/128);
Has the type being changed somewhere in the past or why is this so?
--
i.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
