On Fri, May 8, 2020 at 10:58 AM Soheil Hassas Yeganeh <soh...@google.com> wrote:
>
> On Fri, May 8, 2020 at 10:45 AM Eric Dumazet <eric.duma...@gmail.com> wrote:
> >
> >
> >
> > On 5/8/20 7:23 AM, Kelly Littlepage wrote:
> > > The stated intent of the original commit is to is to "return the timestamp
> > > corresponding to the highest sequence number data returned." The current
> > > implementation returns the timestamp for the last byte of the last fully
> > > read skb, which is not necessarily the last byte in the recv buffer. This
> > > patch converts behavior to the original definition, and to the behavior of
> > > the previous draft versions of commit 98aaa913b4ed ("tcp: Extend
> > > SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg") which also match this
> > > behavior.
> > >
> > > Fixes: 98aaa913b4ed ("tcp: Extend SOF_TIMESTAMPING_RX_SOFTWARE to TCP
> > > recvmsg")
> > > Co-developed-by: Iris Liu <i...@onechronos.com>
> > > Signed-off-by: Iris Liu <i...@onechronos.com>
> > > Signed-off-by: Kelly Littlepage <ke...@onechronos.com>
> > > ---
> > > Reverted to the original subject line
> >
> >
> > SGTM, thanks.
> >
> > Signed-off-by: Eric Dumazet <eduma...@google.com>
>
> Acked-by: Soheil Hassas Yeganeh <soh...@google.com>
Acked-by: Willem de Bruijn <will...@google.com>
