On 18/10/2019 21:08:23+0100, Russell King - ARM Linux admin wrote: > On Fri, Oct 18, 2019 at 09:08:10PM +0200, Andrew Lunn wrote: > > On Fri, Oct 18, 2019 at 04:39:24PM +0200, Antoine Tenart wrote: > > > This patch converts the MACB Ethernet driver to the Phylink framework. > > > The MAC configuration is moved to the Phylink ops and Phylink helpers > > > are now used in the ethtools functions. > > What seems to be missing is "why". It isn't obvious from the patch why > this conversion is being done... >
One of the first goal was to get access to phylink_ethtool_get_pauseparam/phylink_ethtool_set_pauseparam and the flow control logic instead of having to open code it. There are also boards with a zynqmp and SFP cages. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com