On Fri, Feb 09, 2007 at 05:43:14AM +0100, Samir Bellabes ([EMAIL PROTECTED])
wrote:
> Hi,
>
> Here is a new feature which can help firewalls to be more application
> aware, so more useful for people.
>
> Our previous discussion about cn_net and firewalls:
> http://marc2.theaimsgroup.com/?t=115976957500002&r=1&w=2
>
> Please, I would really like to have feedback and comments on that tool,
> in order to improve it.
Technical side does have problems.
1. your way to delete and check events is wrong - there is no need to
allocate new event and search for it in the hash table to remove - use
values as is.
2. initialization path has problems - hash is allocated after securty
hooks and connector moduler are registered.
3. why hash table and not rb tree?
4. are you 100% sure there are misalignments and 32/64 bit userspace
problems? you seems to copy some bits from proc connector, which
suffered from that errors in the past.
> Thanks a lot,
> Samir Bellabes
--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
