From: Sameeh Jubran <same...@amazon.com>

The first_interrupt field is accessed in ena_intr_msix_io() upon
receiving an interrupt.The rx_ring and tx_ring fields of napi can
be NULL when receiving interrupt for xdp queues. This patch fixes
the issue by moving the field to the ena_napi struct.

Signed-off-by: Sameeh Jubran <same...@amazon.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 ++++--
 drivers/net/ethernet/amazon/ena/ena_netdev.h | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 5a90163fa..97b333d07 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1809,6 +1809,9 @@ static int ena_io_poll(struct napi_struct *napi, int 
budget)
        tx_ring = ena_napi->tx_ring;
        rx_ring = ena_napi->rx_ring;
 
+       tx_ring->first_interrupt = ena_napi->first_interrupt;
+       rx_ring->first_interrupt = ena_napi->first_interrupt;
+
        tx_budget = tx_ring->ring_size / ENA_TX_POLL_BUDGET_DIVIDER;
 
        if (!test_bit(ENA_FLAG_DEV_UP, &tx_ring->adapter->flags) ||
@@ -1880,8 +1883,7 @@ static irqreturn_t ena_intr_msix_io(int irq, void *data)
 {
        struct ena_napi *ena_napi = data;
 
-       ena_napi->tx_ring->first_interrupt = true;
-       ena_napi->rx_ring->first_interrupt = true;
+       ena_napi->first_interrupt = true;
 
        napi_schedule_irqoff(&ena_napi->napi);
 
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h 
b/drivers/net/ethernet/amazon/ena/ena_netdev.h
index cb0804947..c666a9cac 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
@@ -168,6 +168,7 @@ struct ena_napi {
        struct ena_ring *tx_ring;
        struct ena_ring *rx_ring;
        struct ena_ring *xdp_ring;
+       bool first_interrupt;
        u32 qid;
        struct dim dim;
 };
-- 
2.17.1

Reply via email to