On Wed, 9 Oct 2019 09:20:02 -0700, Eric Dumazet wrote: > As mentioned in > https://github.com/google/ktsan/wiki/READ_ONCE-and-WRITE_ONCE#it-may-improve-performance > a C compiler can legally transform > > if (e->queue_index != queue_index) > e->queue_index = queue_index; > > to : > > e->queue_index = queue_index; > > Note that the code using jiffies has no issue, since jiffies > has volatile attribute. > > if (e->updated != jiffies) > e->updated = jiffies; > > Fixes: 83b1bc122cab ("tun: align write-heavy flow entry members to a cache > line") > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Zhang Yu <zhangy...@baidu.com> > Cc: Wang Li <wangl...@baidu.com> > Cc: Li RongQing <lirongq...@baidu.com> > Cc: Jason Wang <jasow...@redhat.com>
Applied, same story with stable, thanks!