On 10/4/19 11:43 AM, Roopa Prabhu wrote: > On Fri, Oct 4, 2019 at 9:38 AM David Ahern <dsah...@gmail.com> wrote: >> >> On 10/4/19 8:43 AM, Ido Schimmel wrote: >>>> Sounds like there are 2 cases for prefixes that should be flagged to the >>>> user -- "offloaded" (as in traffic is offloaded) and "in_hw" (prefix is >>>> in hardware but forwarding is not offloaded). >>> Sounds good. Are you and Roopa OK with the below? >>> >>> RTM_F_IN_HW - route is in hardware >>> RTM_F_OFFLOAD - route is offloaded >>> >>> For example, host routes will have the first flag set, whereas prefix >>> routes will have both flags set. >> >> if "offload" always includes "in_hw", then are both needed? ie., why not >> document that offload means in hardware with offloaded traffic, and then >> "in_hw" is a lesser meaning - only in hardware with a trap to CPU? > > I was wondering if we can just call these RTM_F_OFFLOAD_TRAP or > RTM_F_OFFLOAD_ASSIT or something along those lines. > > My only concern with the proposed names is, both mean HW offload but > only one uses HW in the name which can be confusing down the lane :).
sounds good to me.
