On Thu, Oct 3, 2019 at 8:31 AM David Miller <da...@davemloft.net> wrote: > > From: Yi-Hung Wei <yihung....@gmail.com> > Date: Mon, 30 Sep 2019 12:39:04 -0700 > > > - if ((nf_ct_is_confirmed(ct) ? !cached : info->commit) && > > + if ((nf_ct_is_confirmed(ct) ? !cached | add_helper : > > I would suggest using "||" instea of "|" here since you are computing > a boolean.
Thanks for review. It makes sense to use "||" rather than "|". I will wait a bit to gather more feedback before I send v2. Thanks, -Yi-Hung
