On Wed, Oct 02, 2019 at 01:11:32PM -0700, Jakub Kicinski wrote: > On Wed, 2 Oct 2019 11:20:52 +0300, same...@amazon.com wrote: > > + > > + new_channel_count = clamp_val(channels->tx_count, > > + ENA_MIN_NUM_IO_QUEUES, channels->max_tx); > > You should return an error if the value is not within bounds, rather > than guessing.
And ethtool_set_channels() already does that if any of the requested counts exceeds the corresponding maximum so that the upper bound check here is superfluous. Michal
