On 23.09.2019 11:33, shubhrajyoti.da...@gmail.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com>
> 
> macb_64b_desc is always called when HW_DMA_CAP_64B is defined.
> So the return NULL can never be reached. Remove the dead code.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com>

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com>

> ---
>  drivers/net/ethernet/cadence/macb_main.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c 
> b/drivers/net/ethernet/cadence/macb_main.c
> index 35b59b5..8e8d557 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -165,9 +165,8 @@ static unsigned int macb_adj_dma_desc_idx(struct macb 
> *bp, unsigned int desc_idx
>  #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
>  static struct macb_dma_desc_64 *macb_64b_desc(struct macb *bp, struct 
> macb_dma_desc *desc)
>  {
> -     if (bp->hw_dma_cap & HW_DMA_CAP_64B)
> -             return (struct macb_dma_desc_64 *)((void *)desc + sizeof(struct 
> macb_dma_desc));
> -     return NULL;
> +     return (struct macb_dma_desc_64 *)((void *)desc
> +             + sizeof(struct macb_dma_desc));
>  }
>  #endif
>  
> 

Reply via email to