Wed, Sep 18, 2019 at 10:01:31PM CEST, dsah...@gmail.com wrote: >On 9/18/19 1:37 AM, Jiri Pirko wrote: >> Wed, Sep 18, 2019 at 01:46:13AM CEST, dsah...@gmail.com wrote: >>> On 9/17/19 12:36 PM, Jiri Pirko wrote: >>>> Tue, Sep 17, 2019 at 06:46:31PM CEST, dsah...@gmail.com wrote: >>>>> On 9/16/19 3:44 AM, Jiri Pirko wrote: >>>>>> From: Jiri Pirko <j...@mellanox.com> >>>>>> >>>>>> Add indication about previous failed devlink reload. >>>>>> >>>>>> Example outputs: >>>>>> >>>>>> $ devlink dev >>>>>> netdevsim/netdevsim10: reload_failed true >>>>> >>>>> odd output to user. Why not just "reload failed"? >>>> >>>> Well it is common to have "name value". The extra space would seem >>>> confusing for the reader.. >>>> Also it is common to have "_" instead of space for the output in cases >>>> like this. >>>> >>> >>> I am not understanding your point. >>> >>> "reload failed" is still a name/value pair. It is short and to the point >>> as to what it indicates. There is no need for the name in the uapi (ie., >>> the name of the netlink attribute) to be dumped here. >> >> Ah, got it. Well it is a bool value, that means it is "true" or "false". >> In json output, it is True of False. App processing json would have to >> handle this case in a special way. >> > >Technically it is a u8. But really I do not understand why it is >RELOAD_FAILED and not RELOAD_STATUS which is more generic and re-usable. >e.g,. 'none', 'failed', 'success'.
I was thinking about that. But I was not able to figure out any other possible values. So it is bool. For indication of some other status, there would have to be independent bool/othertype anyway.
