Re: [patch net-next v2 3/3] net: devlink: move reload fail indication to devlink core and expose to user

[Ido Schimmel]

On Sat, Sep 07, 2019 at 10:54:00PM +0200, Jiri Pirko wrote:
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index 546e75dd74ac..7cb5e8c5ae0d 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -410,6 +410,8 @@ enum devlink_attr {
>       DEVLINK_ATTR_TRAP_METADATA,                     /* nested */
>       DEVLINK_ATTR_TRAP_GROUP_NAME,                   /* string */
>  
> +     DEVLINK_ATTR_RELOAD_FAILED,                     /* u8 0 or 1 */
> +
>       /* add new attributes above here, update the policy in devlink.c */
>  
>       __DEVLINK_ATTR_MAX,
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 1e3a2288b0b2..e00a4a643d17 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -471,6 +471,8 @@ static int devlink_nl_fill(struct sk_buff *msg, struct 
> devlink *devlink,
>  
>       if (devlink_nl_put_handle(msg, devlink))
>               goto nla_put_failure;
> +     if (nla_put_u8(msg, DEVLINK_ATTR_RELOAD_FAILED, devlink->reload_failed))

Why not use NLA_FLAG for this?

> +             goto nla_put_failure;
>  
>       genlmsg_end(msg, hdr);
>       return 0;
> @@ -2677,6 +2679,21 @@ static bool devlink_reload_supported(struct devlink 
> *devlink)
>       return devlink->ops->reload_down && devlink->ops->reload_up;
>  }