On Fri, Sep 06, 2019 at 05:15:41PM +0300, Claudiu Manoil wrote: > +#define enetc_mdio_rd(mdio_priv, off) \ > + _enetc_mdio_rd(mdio_priv, ENETC_##off) > +#define enetc_mdio_wr(mdio_priv, off, val) \ > + _enetc_mdio_wr(mdio_priv, ENETC_##off, val)
Hi Claudiu The MDIO code appears to be the only part of this driver which does these ENETC_##off games. Could you please clean this up and use the full name in the enetc_mdio_rd() and enetc_mdio_wr() calls. Otherwise this looks good. Andrew