On 9/3/19 6:17 AM, Maciej Żenczykowski wrote: > Well, if you look at the commit my commit is fixing, ie. > commit c7a1ce397adacaf5d4bb2eab0a738b5f80dc3e43 > then you'll see this in the commit description: > "- dst_nocount is handled by the RTF_ADDRCONF flag" > and the patch diff itself is from > "f6i->fib6_flags = RTF_UP | RTF_NONEXTHOP; > f6i->dst_nocount = true;" > to > " .fc_flags = RTF_UP | RTF_ADDRCONF | RTF_NONEXTHOP," > > (and RTF_ANYCAST or RTF_LOCAL is later or'ed in in both versions of the code) > > so I'm pretty sure that patch adds ADDRCONF unconditionally to that > function, and my commit unconditionally removes it. >
exactly. It was shortsighted of me to add the ADDRCONF flag and removing it reverts back to the previous behavior. When I enable radvd, I do see the flag set when it should be and not for other addresses. I believe the patch is correct.
