Hi Cyrus, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [cannot apply to v5.3-rc7 next-20190902] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Cyrus-Sh/Clock-independent-TCP-ISN-generation/20190903-131719 config: x86_64-randconfig-e003-201935 (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): >> kernel/sysctl_binary.c:335:42: error: expected '}' before string constant {CTL_INT, NET_IPV4_TCP_RANDOM_ISN "tcp_random_isn"} ^~~~~~~~~~~~~~~~ >> kernel/sysctl_binary.c:336:2: error: expected '}' before '{' token {CTL_INT, NET_IPV4_FORWARD, "ip_forward" }, ^ vim +335 kernel/sysctl_binary.c 333 334 static const struct bin_table bin_net_ipv4_table[] = { > 335 {CTL_INT, NET_IPV4_TCP_RANDOM_ISN "tcp_random_isn"} > 336 {CTL_INT, NET_IPV4_FORWARD, > "ip_forward" }, 337 338 { CTL_DIR, NET_IPV4_CONF, "conf", bin_net_ipv4_conf_table }, 339 { CTL_DIR, NET_IPV4_NEIGH, "neigh", bin_net_neigh_table }, 340 { CTL_DIR, NET_IPV4_ROUTE, "route", bin_net_ipv4_route_table }, 341 /* NET_IPV4_FIB_HASH unused */ 342 { CTL_DIR, NET_IPV4_NETFILTER, "netfilter", bin_net_ipv4_netfilter_table }, 343 344 { CTL_INT, NET_IPV4_TCP_TIMESTAMPS, "tcp_timestamps" }, 345 { CTL_INT, NET_IPV4_TCP_WINDOW_SCALING, "tcp_window_scaling" }, 346 { CTL_INT, NET_IPV4_TCP_SACK, "tcp_sack" }, 347 { CTL_INT, NET_IPV4_TCP_RETRANS_COLLAPSE, "tcp_retrans_collapse" }, 348 { CTL_INT, NET_IPV4_DEFAULT_TTL, "ip_default_ttl" }, 349 /* NET_IPV4_AUTOCONFIG unused */ 350 { CTL_INT, NET_IPV4_NO_PMTU_DISC, "ip_no_pmtu_disc" }, 351 { CTL_INT, NET_IPV4_NONLOCAL_BIND, "ip_nonlocal_bind" }, 352 { CTL_INT, NET_IPV4_TCP_SYN_RETRIES, "tcp_syn_retries" }, 353 { CTL_INT, NET_TCP_SYNACK_RETRIES, "tcp_synack_retries" }, 354 { CTL_INT, NET_TCP_MAX_ORPHANS, "tcp_max_orphans" }, 355 { CTL_INT, NET_TCP_MAX_TW_BUCKETS, "tcp_max_tw_buckets" }, 356 { CTL_INT, NET_IPV4_DYNADDR, "ip_dynaddr" }, 357 { CTL_INT, NET_IPV4_TCP_KEEPALIVE_TIME, "tcp_keepalive_time" }, 358 { CTL_INT, NET_IPV4_TCP_KEEPALIVE_PROBES, "tcp_keepalive_probes" }, 359 { CTL_INT, NET_IPV4_TCP_KEEPALIVE_INTVL, "tcp_keepalive_intvl" }, 360 { CTL_INT, NET_IPV4_TCP_RETRIES1, "tcp_retries1" }, 361 { CTL_INT, NET_IPV4_TCP_RETRIES2, "tcp_retries2" }, 362 { CTL_INT, NET_IPV4_TCP_FIN_TIMEOUT, "tcp_fin_timeout" }, 363 { CTL_INT, NET_TCP_SYNCOOKIES, "tcp_syncookies" }, 364 { CTL_INT, NET_TCP_TW_RECYCLE, "tcp_tw_recycle" }, 365 { CTL_INT, NET_TCP_ABORT_ON_OVERFLOW, "tcp_abort_on_overflow" }, 366 { CTL_INT, NET_TCP_STDURG, "tcp_stdurg" }, 367 { CTL_INT, NET_TCP_RFC1337, "tcp_rfc1337" }, 368 { CTL_INT, NET_TCP_MAX_SYN_BACKLOG, "tcp_max_syn_backlog" }, 369 { CTL_INT, NET_IPV4_LOCAL_PORT_RANGE, "ip_local_port_range" }, 370 { CTL_INT, NET_IPV4_IGMP_MAX_MEMBERSHIPS, "igmp_max_memberships" }, 371 { CTL_INT, NET_IPV4_IGMP_MAX_MSF, "igmp_max_msf" }, 372 { CTL_INT, NET_IPV4_INET_PEER_THRESHOLD, "inet_peer_threshold" }, 373 { CTL_INT, NET_IPV4_INET_PEER_MINTTL, "inet_peer_minttl" }, 374 { CTL_INT, NET_IPV4_INET_PEER_MAXTTL, "inet_peer_maxttl" }, 375 { CTL_INT, NET_IPV4_INET_PEER_GC_MINTIME, "inet_peer_gc_mintime" }, 376 { CTL_INT, NET_IPV4_INET_PEER_GC_MAXTIME, "inet_peer_gc_maxtime" }, 377 { CTL_INT, NET_TCP_ORPHAN_RETRIES, "tcp_orphan_retries" }, 378 { CTL_INT, NET_TCP_FACK, "tcp_fack" }, 379 { CTL_INT, NET_TCP_REORDERING, "tcp_reordering" }, 380 { CTL_INT, NET_TCP_ECN, "tcp_ecn" }, 381 { CTL_INT, NET_TCP_DSACK, "tcp_dsack" }, 382 { CTL_INT, NET_TCP_MEM, "tcp_mem" }, 383 { CTL_INT, NET_TCP_WMEM, "tcp_wmem" }, 384 { CTL_INT, NET_TCP_RMEM, "tcp_rmem" }, 385 { CTL_INT, NET_TCP_APP_WIN, "tcp_app_win" }, 386 { CTL_INT, NET_TCP_ADV_WIN_SCALE, "tcp_adv_win_scale" }, 387 { CTL_INT, NET_TCP_TW_REUSE, "tcp_tw_reuse" }, 388 { CTL_INT, NET_TCP_FRTO, "tcp_frto" }, 389 { CTL_INT, NET_TCP_FRTO_RESPONSE, "tcp_frto_response" }, 390 { CTL_INT, NET_TCP_LOW_LATENCY, "tcp_low_latency" }, 391 { CTL_INT, NET_TCP_NO_METRICS_SAVE, "tcp_no_metrics_save" }, 392 { CTL_INT, NET_TCP_MODERATE_RCVBUF, "tcp_moderate_rcvbuf" }, 393 { CTL_INT, NET_TCP_TSO_WIN_DIVISOR, "tcp_tso_win_divisor" }, 394 { CTL_STR, NET_TCP_CONG_CONTROL, "tcp_congestion_control" }, 395 { CTL_INT, NET_TCP_MTU_PROBING, "tcp_mtu_probing" }, 396 { CTL_INT, NET_TCP_BASE_MSS, "tcp_base_mss" }, 397 { CTL_INT, NET_IPV4_TCP_WORKAROUND_SIGNED_WINDOWS, "tcp_workaround_signed_windows" }, 398 { CTL_INT, NET_TCP_SLOW_START_AFTER_IDLE, "tcp_slow_start_after_idle" }, 399 { CTL_INT, NET_CIPSOV4_CACHE_ENABLE, "cipso_cache_enable" }, 400 { CTL_INT, NET_CIPSOV4_CACHE_BUCKET_SIZE, "cipso_cache_bucket_size" }, 401 { CTL_INT, NET_CIPSOV4_RBM_OPTFMT, "cipso_rbm_optfmt" }, 402 { CTL_INT, NET_CIPSOV4_RBM_STRICTVALID, "cipso_rbm_strictvalid" }, 403 /* NET_TCP_AVAIL_CONG_CONTROL "tcp_available_congestion_control" no longer used */ 404 { CTL_STR, NET_TCP_ALLOWED_CONG_CONTROL, "tcp_allowed_congestion_control" }, 405 { CTL_INT, NET_TCP_MAX_SSTHRESH, "tcp_max_ssthresh" }, 406 407 { CTL_INT, NET_IPV4_ICMP_ECHO_IGNORE_ALL, "icmp_echo_ignore_all" }, 408 { CTL_INT, NET_IPV4_ICMP_ECHO_IGNORE_BROADCASTS, "icmp_echo_ignore_broadcasts" }, 409 { CTL_INT, NET_IPV4_ICMP_IGNORE_BOGUS_ERROR_RESPONSES, "icmp_ignore_bogus_error_responses" }, 410 { CTL_INT, NET_IPV4_ICMP_ERRORS_USE_INBOUND_IFADDR, "icmp_errors_use_inbound_ifaddr" }, 411 { CTL_INT, NET_IPV4_ICMP_RATELIMIT, "icmp_ratelimit" }, 412 { CTL_INT, NET_IPV4_ICMP_RATEMASK, "icmp_ratemask" }, 413 414 { CTL_INT, NET_IPV4_IPFRAG_HIGH_THRESH, "ipfrag_high_thresh" }, 415 { CTL_INT, NET_IPV4_IPFRAG_LOW_THRESH, "ipfrag_low_thresh" }, 416 { CTL_INT, NET_IPV4_IPFRAG_TIME, "ipfrag_time" }, 417 418 { CTL_INT, NET_IPV4_IPFRAG_SECRET_INTERVAL, "ipfrag_secret_interval" }, 419 /* NET_IPV4_IPFRAG_MAX_DIST "ipfrag_max_dist" no longer used */ 420 421 { CTL_INT, 2088 /* NET_IPQ_QMAX */, "ip_queue_maxlen" }, 422 423 /* NET_TCP_DEFAULT_WIN_SCALE unused */ 424 /* NET_TCP_BIC_BETA unused */ 425 /* NET_IPV4_TCP_MAX_KA_PROBES unused */ 426 /* NET_IPV4_IP_MASQ_DEBUG unused */ 427 /* NET_TCP_SYN_TAILDROP unused */ 428 /* NET_IPV4_ICMP_SOURCEQUENCH_RATE unused */ 429 /* NET_IPV4_ICMP_DESTUNREACH_RATE unused */ 430 /* NET_IPV4_ICMP_TIMEEXCEED_RATE unused */ 431 /* NET_IPV4_ICMP_PARAMPROB_RATE unused */ 432 /* NET_IPV4_ICMP_ECHOREPLY_RATE unused */ 433 /* NET_IPV4_ALWAYS_DEFRAG unused */ 434 {} 435 }; 436 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
