On 28.08.2019 01:27, Andrew Lunn wrote: > On Tue, Aug 27, 2019 at 08:41:00PM +0200, Heiner Kallweit wrote: >> This patch prepares the driver for adding RTL8125 support: >> - change type of interrupt mask to u32 >> - restrict rtl_is_8168evl_up to RTL8168 chip versions >> - factor out reading MAC address from registers >> - re-add function rtl_get_events >> - move disabling interrupt coalescing to RTL8169/RTL8168 init >> - read different register for PCI commit >> - don't use bit LastFrag in tx descriptor after send, RTL8125 clears it > > Hi Heiner > > That is a lot of changes in one patch. Although there is no planned > functional change, r8169 has a habit of breaking. Having lots of small > changes would help tracking down which change caused a breakage, via a > git bisect. > > So you might want to consider splitting this up into a number of small > patches. > > Andrew > Hi Andrew,
most of the changes are trivial, but you're right. I'll split this patch. Heiner
