On Fri, Aug 16, 2019 at 03:44:42AM +0300, Vladimir Oltean wrote: > This patch addresses some cosmetic issues: > - Alignment > - Typos > - (Non-)use of BIT() and GENMASK() macros > - Unused definitions > - Unused includes > - Abuse of ternary operator in detriment of readability > - Reduce indentation level
This is difficult to review since there's a bunch of largely unrelated changes all munged into one patch. It'd be better to split this up so each change makes one kind of fix, and better to do this separately to the rest of the series. In particular having alignment changes along with other changes hurts reviewability as it's less immediately clear what's a like for liken substitution.
signature.asc
Description: PGP signature
