On Mon, 5 Aug 2019 08:29:36 -0700, Stanislav Fomichev wrote: > On 08/05, Peter Wu wrote: > > /proc/config has never existed as far as I can see, but /proc/config.gz > > is present on Arch Linux. Execute an external gunzip program to avoid > > linking to zlib and rework the option scanning code since a pipe is not > > seekable. This also fixes a file handle leak on some error paths. > Thanks for doing that! One question: why not link against -lz instead? > With fork/execing gunzip you're just hiding this dependency. > > You can add something like this to the Makefile: > ifeq ($(feature-zlib),1) > CLFAGS += -DHAVE_ZLIB > endif > > And then conditionally add support for config.gz. Thoughts?
+1
