On Fri, Aug 02, 2019 at 06:39:52PM -0700, Matthew Wilcox wrote: > On Fri, Aug 02, 2019 at 06:30:31PM -0700, Nathan Chancellor wrote: > > On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote: > > > The proper way to fix this is to include either > > > > > > linux/io-64-nonatomic-hi-lo.h > > > > > > or > > > > > > linux/io-64-nonatomic-lo-hi.h > > > > > > whichever is appropriate. > > > > Hmmmm, is that not what I did? > > > > Although I did not know about io-64-nonatomic-hi-lo.h. What is the > > difference and which one is needed here? > > Whether you write the high or low 32 bits first. For this, it doesn't > matter, since the compiled driver will never be run on real hardware.
That's what I figured. I have only seen lo-hi used personally, which is what I went with here. Thanks for the confirmation! > > > There is apparently another failure when OF_MDIO is not set, I guess I > > can try to look into that as well and respin into a series if > > necessary. > > Thanks for taking care of that!
