On 8/2/19 9:15 AM, Alexei Starovoitov wrote: > On Thu, Aug 1, 2019 at 9:11 PM David Ahern <dsah...@gmail.com> wrote: >> >> On 8/1/19 6:19 PM, Alexei Starovoitov wrote: >>> Do you really need 'sleep 1' everywhere? >>> It makes them so slow to run... >>> What happens if you just remove it ? Tests will fail? Why? >> >> yes, the sleep 1 is needed. A server process is getting launched into >> the background. It's status is not relevant; the client's is the key. >> The server needs time to initialize. And, yes I tried forking and it >> gets hung up with bash and capturing the output for verbose mode. > > That means that the tests are not suitable for CI servers > where cpus are pegged to 100% and multiple tests run in parallel. > The test will be flaky :( >
once the tests exist, they can be improved - by me or anyone else that has the time and interest.
