On Wed, 24 Jul 2019 09:18:38 +0100 Sergei Trofimovich <sly...@gentoo.org> wrote:
> On sys/queue.h does not exist linux-musl targets and > fails build as: > > devlink.c:28:10: fatal error: sys/queue.h: No such file or directory > 28 | #include <sys/queue.h> > | ^~~~~~~~~~~~~ > > The change pulls in 'sys/queue.h' from libbsd in case > system headers don't already provides it. > > Tested on linux-musl and linux-glibc. > > Bug: https://bugs.gentoo.org/690486 > CC: Stephen Hemminger <step...@networkplumber.org> > CC: netdev@vger.kernel.org > Signed-off-by: Sergei Trofimovich <sly...@gentoo.org> > --- This is ugly and causes more maintainability issues. Maybe just fix devlink not to depend on sys/queue.h at all. It makes more sense to have common code style and usage across all of iproute2. We already have local version list.h, why continue with BSD stuff.
