On 7/23/19 7:28 PM, Ioana Radulescu wrote:
> Using Rx skb bulking for all frames may negatively impact the
> performance in some TCP termination scenarios, as it effectively
> bypasses GRO.
>
> - list_add_tail(&skb->list, ch->rx_list);
> + if (frame_is_tcp(fd, fas))
> + napi_gro_receive(&ch->napi, skb);
> + else
> + list_add_tail(&skb->list, ch->rx_list);
>
> return;
>
This is really bad.
This is exactly why I suggested to add the batching capability to GRO,
instead having to change all drivers.
Edward Cree is working on this.
