On Mon, 2019-07-15 at 11:13 +0200, Michal Kubecek wrote:
> > +   /*
> > +    * Starting from kernel version 5.3 the registers dump buffer grew from
> > +    * 739 4-byte words to 740 words, and word 740 contains the RR2DCDLAY
> 
> nit: "E" missing here:                                                    ^

Fixed and sent out v2.

> > +   fprintf(stdout,
> > +           "0x05BF4: RR2DCDELAY  (Max. DMA read delay)            
> > 0x%08X\n",
> > +           regs_buff[739]);
> 
> Showing a delay as hex number doesn't seem very user friendly but that
> also applies to many existing registers so it's probably better to be
> consistent and perhaps do an overall cleanup later.

Agree.

Thanks!

Reply via email to