On Tue, Jul 9, 2019 at 7:31 PM Mahesh Bandewar (महेश बंडेवार) <mahe...@google.com> wrote: > > On Tue, Jul 9, 2019 at 6:16 AM Andrea Claudi <acla...@redhat.com> wrote: > > > > This reverts commit ba126dcad20e6d0e472586541d78bdd1ac4f1123. > > It breaks tunnel creation when using 'dev' parameter: > > > > $ ip link add type dummy > > $ ip -6 tunnel add ip6tnl1 mode ip6ip6 remote 2001:db8:ffff:100::2 local > > 2001:db8:ffff:100::1 hoplimit 1 tclass 0x0 dev dummy0 > > add tunnel "ip6tnl0" failed: File exists > > > > dev parameter must be used to specify the device to which > > the tunnel is binded, and not the tunnel itself. > > > > Reported-by: Jianwen Ji <j...@redhat.com> > > Reviewed-by: Matteo Croce <mcr...@redhat.com> > > Signed-off-by: Andrea Claudi <acla...@redhat.com> > > --- > > ip/ip6tunnel.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c > > index 56fd3466ed062..999408ed801b1 100644 > > --- a/ip/ip6tunnel.c > > +++ b/ip/ip6tunnel.c > > @@ -298,8 +298,6 @@ static int parse_args(int argc, char **argv, int cmd, > > struct ip6_tnl_parm2 *p) > > p->link = ll_name_to_index(medium); > > if (!p->link) > > return nodev(medium); > > - else > > - strlcpy(p->name, medium, sizeof(p->name)); > NACK > > I see that ba126dcad20e6d0e472586541d78bdd1ac4f1123 has broke > something but that doesn't mean revert of the original fix is correct > way of fixing it. The original fix is fixing the show and change > command. Shouldn't you try fixing the add command so that all (show, > change, and add) work correctly? >
Hi Mahesh, Thanks for sharing your opinion. I think I already answered this replying to your review of patch 2/2 of this series. To summarize that up I think there is a misunderstanding on the meaning of "dev" param, and "name" param (which is the default) must be used instead in the cases highlighted in your commit. Regards, Andrea > > } > > return 0; > > } > > -- > > 2.20.1 > >
