On 7/8/2019 6:28 PM, Florian Westphal wrote:
> Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> wrote:
>>> +   } else { /* NFPROTO_IPV6 */
>>> +           enum ip6_defrag_users user = IP6_DEFRAG_CONNTRACK_IN + zone;
>>> +
>>> +           memset(IP6CB(skb), 0, sizeof(struct inet6_skb_parm));
>>> +           err = nf_ct_frag6_gather(net, skb, user);
>> This doesn't build without IPv6 enabled.
>> ERROR: "nf_ct_frag6_gather" [net/sched/act_ct.ko] undefined!
>>
>> We need to (copy and pasted):
>>
>> @@ -179,7 +179,9 @@ static int tcf_ct_handle_fragments(struct net *net, 
>> struct sk_buff *skb,
>>                  local_bh_enable();
>>                  if (err && err != -EINPROGRESS)
>>                          goto out_free;
>> -       } else { /* NFPROTO_IPV6 */
>> +       }
>> +#if IS_ENABLED(IPV6)
>> +       else { /* NFPROTO_IPV6 */
>>                  enum ip6_defrag_users user = IP6_DEFRAG_CONNTRACK_IN + zone;
> Good catch, but it should be
> #if IS_ENABLED(CONFIG_NF_DEFRAG_IPV6)
> just like ovs conntrack.c ,



Thanks guys.

Reply via email to