On Fri, 5 Jul 2019 01:48:40 +0200, Pablo Neira Ayuso wrote: > Remove the global flow_block_cb_list, replace it by per-driver list > of flow block objects. This will make it easier later on to support > for policy hardware offload of multiple subsystems. > > Suggested-by: Jiri Pirko <j...@resnulli.us> > Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
I don't understand the need for a per driver list of callbacks. Your concern seems to be that drivers will get confused by multiple subsystems trying to bind blocks. We have a feature flag for TC offloads, why can't netfilter have one too? Way simpler. If I may comment on the patches in general this series is really hard to follow. Changes are split into patches in a strange way, and the number of things called some combination of block cb and list makes my head hurt :/
