On 7/1/2019 9:46 AM, Ran Rozenstein wrote: > > >> -----Original Message----- >> From: Tariq Toukan >> Sent: Sunday, June 30, 2019 10:57 >> To: David Miller <da...@davemloft.net>; f...@strlen.de >> Cc: netdev@vger.kernel.org; Ran Rozenstein <ra...@mellanox.com>; Tariq >> Toukan <tar...@mellanox.com> >> Subject: Re: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop >> >> >> >> On 6/27/2019 7:54 PM, David Miller wrote: >>> From: Florian Westphal <f...@strlen.de> >>> Date: Thu, 27 Jun 2019 14:03:31 +0200 >>> >>>> Tariq and Ran reported a regression caused by net-next commit >>>> 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list"). >>>> >>>> This happens when net.ipv4.conf.$dev.promote_secondaries sysctl is >>>> enabled -- we can arrange for ifa->next to point at ifa, so next >>>> process that tries to walk the list loops forever. >>>> >>>> Fix this and extend rtnetlink.sh with a small test case for this. >>> >>> Series applied, thanks Florian. >>> >> >> Thanks Florian! >> >> Ran, please test and update. >> >> Tariq > > Thanks Florian. > Didn't reproduce tonight with the fixes. > > Ran. >
Sounds good! Thanks, Tariq