From: Paul Blakey <pa...@mellanox.com>
Date: Thu, 20 Jun 2019 16:42:18 +0300

> +struct tcf_ct_params {
 ...
> +     struct rcu_head rcu;
> +
> +};

Please get ride of that empty line after the 'rcu' member.

> +     switch (skb->protocol) {
> +     case htons(ETH_P_IP):
> +             family = NFPROTO_IPV4;
> +             break;
> +     case htons(ETH_P_IPV6):
> +             family = NFPROTO_IPV6;
> +             break;
> +     default:
> +     break;

Break statement is not indented properly.

> +static __net_init int ct_init_net(struct net *net)
> +{
> +     struct tc_ct_action_net *tn = net_generic(net, ct_net_id);
> +     unsigned int n_bits = FIELD_SIZEOF(struct tcf_ct_params, labels) * 8;

Reverse christmas tree here please.

Reply via email to