On Wed, Jun 26, 2019 at 7:37 AM Benjamin Poirier <bpoir...@suse.com> wrote: > > On 2019/06/26 09:24, Manish Chopra wrote: > > > -----Original Message----- > > > From: Benjamin Poirier <bpoir...@suse.com> > > > Sent: Monday, June 17, 2019 1:19 PM > > > To: Manish Chopra <mani...@marvell.com>; GR-Linux-NIC-Dev <GR-Linux- > > > nic-...@marvell.com>; netdev@vger.kernel.org > > > Subject: [EXT] [PATCH net-next 03/16] qlge: Deduplicate lbq_buf_size > > > > > > External Email > > > > > > ---------------------------------------------------------------------- > > > lbq_buf_size is duplicated to every rx_ring structure whereas > > > lbq_buf_order is > > > present once in the ql_adapter structure. All rings use the same buf > > > size, keep > > > only one copy of it. Also factor out the calculation of lbq_buf_size > > > instead of > > > having two copies. > > > > > > Signed-off-by: Benjamin Poirier <bpoir...@suse.com> > > > --- > [...] > > > > Not sure if this change is really required, I think fields relevant to > > rx_ring should be present in the rx_ring structure. > > There are various other fields like "lbq_len" and "lbq_size" which would be > > same for all rx rings but still under the relevant rx_ring structure.
The one argument against deduplicating might be if the original fields are in a hot cacheline and the new location adds a cacheline access to a hot path. Not sure if that is relevant here. But maybe something to double check.
