On Wed, Jun 26, 2019 at 7:40 AM Benjamin Poirier <bpoir...@suse.com> wrote: > > On 2019/06/26 09:36, Manish Chopra wrote: > > > -----Original Message----- > > > From: Benjamin Poirier <bpoir...@suse.com> > > > Sent: Monday, June 17, 2019 1:19 PM > > > To: Manish Chopra <mani...@marvell.com>; GR-Linux-NIC-Dev <GR-Linux- > > > nic-...@marvell.com>; netdev@vger.kernel.org > > > Subject: [EXT] [PATCH net-next 05/16] qlge: Remove rx_ring.sbq_buf_size > > > > > > External Email > > > > > > ---------------------------------------------------------------------- > > > Tx rings have sbq_buf_size = 0 but there's no case where the code actually > > > tests on that value. We can remove sbq_buf_size and use a constant > > > instead. > > > > > > > Seems relevant to RX ring, not the TX ring ? > > qlge uses "struct rx_ring" for rx and for tx completion rings. > > The driver's author is probably laughing now at the success of his plan > to confuse those who would follow in his footsteps.
:-) Reviewed-by: Willem de Bruijn <will...@google.com>
