On Tue, 2019-06-25 at 17:47 +0200, Davide Caratti wrote: > On Thu, 2019-06-20 at 10:33 -0700, Cong Wang wrote: > > On Thu, Jun 20, 2019 at 5:52 AM Davide Caratti <dcara...@redhat.com> wrote: > > > hello Cong, thanks for reading. > > > > > > On Wed, 2019-06-19 at 15:04 -0700, Cong Wang wrote: > > > > On Wed, Jun 19, 2019 at 2:10 PM Davide Caratti <dcara...@redhat.com> > > > > wrote: > > > > > on some CPUs (e.g. i686), tcf_walker.cookie has the same size as the > > > > > IDR. > > > > > In this situation, the following script: > > > > > > > > > > # tc filter add dev eth0 ingress handle 0xffffffff flower action ok > > > > > # tc filter show dev eth0 ingress > > > > > > > > > > results in an infinite loop. > > So, when the radix tree contains one slot with index equal to ULONG_MAX, > whatever can be the value of 'id',
oops, this phrase is of course wrong. the value of 'id' matters to determine the condition of the if(). > the condition in that if() will always > be false (and the function will keep returning non-NULL, hence the > infinite loop). what I wanted to say is, when the radix tree contains a single slot with index equal to ULONG_MAX, whatever value I put in 'id' the function will always return a pointer to that slot. -- davide
