From: Jakub Kicinski <jakub.kicin...@netronome.com> Date: Mon, 24 Jun 2019 13:19:52 -0700
> On Thu, 20 Jun 2019 13:24:06 -0700, Shannon Nelson wrote: >> 28 files changed, 9970 insertions(+) > > Dave, could we consider setting a LoC limit for series and patches? > I know this is a new driver, but there's gotta be a way to split > this up more, even if it's painful for the submitter :S > > All the debugfs stuff shouldn't be necessary in the first version, > just looking at first 2 patches... I hear what you're saying. But I have to balance this with the concern for creating a barrier for entry to submitting new drivers. However, looking from another perspective you are right that review burdon is not purely on a number of patches level, but rather the product of number of patches and lines per patch and thus LoC. I'd hate to specify a hard nuber and would rather try to apply judgment onto individual submissions and deal with it on a case by case basis. If someone thinks a submission is too large, anyone can just say that and we'll see what happens. Thanks.
