> -----Original Message----- > From: David Miller <da...@davemloft.net> > Sent: Monday, June 17, 2019 2:09 AM > To: maur...@linux.vnet.ibm.com > Cc: netdev@vger.kernel.org; Ariel Elior <ael...@marvell.com>; Sudarsana > Reddy Kalluru <skall...@marvell.com>; GR-everest-linux-l2 <GR-everest- > linux...@marvell.com> > Subject: Re: [PATCH net] bnx2x: Check if transceiver implements DDM before > access > > From: "Mauro S. M. Rodrigues" <maur...@linux.vnet.ibm.com> > Date: Thu, 13 Jun 2019 16:25:40 -0300 > > > Some transceivers may comply with SFF-8472 even though they do not > > implement the Digital Diagnostic Monitoring (DDM) interface described > > in the spec. The existence of such area is specified by the 6th bit of > > byte 92, set to 1 if implemented. > > > > Currently, without checking this bit, bnx2x fails trying to read sfp > > module's EEPROM with the follow message: > > > > ethtool -m enP5p1s0f1 > > Cannot get Module EEPROM data: Input/output error > > > > Because it fails to read the additional 256 bytes in which it is > > assumed to exist the DDM data. > > > > This issue was noticed using a Mellanox Passive DAC PN 01FT738. The > > EEPROM data was confirmed by Mellanox as correct and similar to other > > Passive DACs from other manufacturers. > > > > Signed-off-by: Mauro S. M. Rodrigues <maur...@linux.vnet.ibm.com> > > Marvell folks, please review.
Acked-by: Sudarsana Reddy Kalluru <skall...@marvell.com>
