Re: [PATCH RFC 09/13] net: phy: marvell: Add cable test support

[Florian Fainelli]

On 6/12/2019 9:05 AM, Andrew Lunn wrote:
> The Marvell PHYs have a couple of different register sets for
> performing cable tests. Page 7 provides the simplest to use. However,
> it does not provide cable length, only length to a fault, when there
> is a fault.
> 
> Signed-off-by: Andrew Lunn <and...@lunn.ch>
> ---
[snip]

> +     bmcr = phy_read(phydev, MII_BMCR);
> +     if (bmcr < 0)
> +             return bmcr;
> +
> +     bmsr = phy_read(phydev, MII_BMCR);

Should this second read be for MII_BMSR?
-- 
Florian